Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, table: allow using SHARD_ROW_ID_BITS with auto_incremental colum… #10788

Merged
merged 1 commit into from
Jun 13, 2019
Merged

ddl, table: allow using SHARD_ROW_ID_BITS with auto_incremental colum… #10788

merged 1 commit into from
Jun 13, 2019

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Jun 12, 2019

Cherry-pick #10759

@bb7133
Copy link
Member Author

bb7133 commented Jun 12, 2019

PTAL @coocood @crazycs520 @tiancaiamao

lonng
lonng reviewed Jun 13, 2019
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 13, 2019
@crazycs520
Copy link
Contributor

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@winkyao winkyao merged commit c16db9d into pingcap:release-2.1 Jun 13, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
@bb7133 bb7133 deleted the bb7133/cherry-pick_10759_2.1 branch December 29, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonng lonng lonng left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bb7133 @tiancaiamao @crazycs520 @lonng @winkyao @you06